[bug 741796] Remove fixture usage in messages/tests.#553
Closed
rlr wants to merge 1 commit intomozilla:masterfrom
Closed
[bug 741796] Remove fixture usage in messages/tests.#553rlr wants to merge 1 commit intomozilla:masterfrom
rlr wants to merge 1 commit intomozilla:masterfrom
Conversation
Member
There was a problem hiding this comment.
I think I would specify usernames here given that you're testing usernames later.
Sure, if not specified, usernames are randomly generated. But given that it's part of the test, I think it's better to define it in the test. e.g.
self.sender = user(username=u'Alice', save=True)
self.to = user(username=u'Bob', save=True)
Member
|
Other than that minor issue, this looks good. r+ |
Contributor
Author
This was referenced Aug 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
r?